Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete workarround for pyton2.7 #2112

Merged
merged 2 commits into from
Jan 30, 2025
Merged

delete workarround for pyton2.7 #2112

merged 2 commits into from
Jan 30, 2025
+1 −4

Conversation

Polandia94
Copy link
Contributor

@Polandia94 Polandia94 commented Dec 3, 2024 •
edited
Loading

This workarround is only for unsoportted python 2.7

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Delete the old workarround. as documented on https://bugs.python.org/issue7980 is only for python2.7

  4. (Optional) PR for stored-proc connector:

@sfc-gh-mkeller sfc-gh-mkeller mentioned this pull request Jan 29, 2025
Draft
@sfc-gh-mkeller sfc-gh-mkeller added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Jan 29, 2025
sfc-gh-mkeller
sfc-gh-mkeller approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@Polandia94 @sfc-gh-mkeller
delete workarround for pyton2.7
749a8ea 
This workarround is only for unsoportted python 2.7
@sfc-gh-mkeller sfc-gh-mkeller merged commit 5bfa659 into snowflakedb:main Jan 30, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Polandia94 @sfc-gh-mkeller